Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#3241 - Icon Alignment issue in Password Field #3263

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

PratyushSawan
Copy link

Fixes #3241

Changes:

Previously, a top margin of 4px was added to the eye icon, which aligned it centrally on some screens but wasn’t consistent for all users. I added a few lines of adjustments to ensure consistency across all screen aspect ratios.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Changes OUTPUTS:
OUTPUT 1:
image

OUTPUT 2:
image

@PratyushSawan
Copy link
Author

@raclim i creating this new PR, because in the last PR #3262 I missed and create a PR directly from the develop branch.

Waiting for your review.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Alignment Issue in Password Field – Adjust Eye Icon Vertical Centering
1 participant