Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the link on line 15 to fix the faux bold issue. #3267

Closed

Conversation

ekambains
Copy link

Fixes #3255

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Nov 6, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim
Copy link
Collaborator

raclim commented Nov 6, 2024

Thanks so much for your work on this!

I'm going to go with PR #3266 for this issue since it was submitted first. I'm sorry that we couldn't get this in, but please feel free to check out our other issues!

@raclim raclim closed this Nov 6, 2024
@ekambains
Copy link
Author

That's ok, this was my first open source contribution so I feel a little sad. But it is first come and first serve so that's how it should be, I will work on something else. It is showing me to delete branch. So can you guide me what to do?

@raclim
Copy link
Collaborator

raclim commented Nov 6, 2024

I'm sorry about that, it did happen pretty quickly 😅 I don't see any additional branch from you on my end, so it might be specific to your repository!

I'm not sure if it's already listed in an issue, but one area I think that could be helpful to get some extra eyes on if it sounds like something you might be interested in is our documentation! We're always open to any improvements needed in our translations for the p5.js editor (if you're fluent in another language) or the contributor docs. You can also look into adding translations for our contributor docs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faux bold applied on functions by the theme
2 participants