Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6847: Update mouseButton value when one mouse button is released #6943

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Renatolo
Copy link

@Renatolo Renatolo commented Apr 6, 2024

Resolves #6847

Changes:

  • Modified src/events/mouse.js to correctly update the mouseButton value upon releasing one mouse button.
  • Updated documentation in src/events/mouse.js accordingly.
  • Added unit test in test/unit/events/mouse.js to cover scenario described in the issue.
  • Now mouseButton should have the value corresponding to the last mouse button pressed/released

Screenshots of the change:
(no screenshots)

PR Checklist

…s released

- Modified src/events/mouse.js to correctly update the mouseButton value upon releasing one mouse button.
- Updated documentation in src/events/mouse.js accordingly.
- Added unit test in test/unit/events/mouse.js to cover scenario described in the issue.
Copy link

welcome bot commented Apr 6, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@limzykenneth
Copy link
Member

This technically changes the behavior of the property and is a breaking change. I don't think I can accept this solution because of it.

@Renatolo
Copy link
Author

Renatolo commented Jun 19, 2024

This technically changes the behavior of the property and is a breaking change. I don't think I can accept this solution because of it.

Thank you for spending time reviewing my PR, I looked further into this issue and learnt that the main reason that the mouseButton was not updated after a mouse release event due to possible problems caused by the context menu being opened... Should I try to make it so that the context menu woulndt interfere in its value (with it still being the default behaviour) or would it still be a breaking change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mouseButton contains incorrect value after pressing both mouse buttons and releasing one of them
2 participants