Expand keyIsDown() to work with characters as arguments #6993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@wwwld1 We are ready to start merging things into the dev-2.0 branch. Is this ready for review? Don't worry about the merge conflict, I can help resolve it. |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6798
Changes:
This is a working draft of this issue #6798 which allows for
keyIsDown()to accept alphanumeric String params such as'w'or'W'. Regarding the confusing case of the int4versus string'4', this implementation includes both where the string parameter e.g.'4'reflects the ASCII value of'4'while the int parameter e.g.4reflects the ASCII code4.The documentation is also updated to reflect the changes with examples now included for the new changes.
Screenshots of the change:
PR Checklist
npm run lintpasses