Changed the contributor docs, removed the broken link #7359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
17 tasks
perminder-17
reviewed
Nov 7, 2024
There was a problem hiding this comment.
Thank you, @iamnikhilranjan, for your work on this! The link is breaking because the old website is revamped. I really appreciate your efforts.
| - Examples: [src/data/examples/assets](https://github.com/processing/p5.js-website/tree/main/src/data/examples) | ||
| - Reference Pages: [src/templates/pages/reference/assets](https://github.com/processing/p5.js-website/tree/main/src/templates/pages/reference/assets) | ||
| - Learn Pages: [src/assets/learn](https://github.com/processing/p5.js-website/tree/main/src/assets/learn) | ||
| - [public/assets](https://github.com/processing/p5.js-website/tree/main/public) |
There was a problem hiding this comment.
Since we’ve now moved both the examples and references to public/assets as part of the website revamp, should we consider using the link https://github.com/processing/p5.js-website/tree/main/public/assets as a reference? Also, it could look something like -Reference Pages : public/assets . What you feel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7220
Changes:
I resolved this by locating the image used in the example within the public/assets folder and replaced all three links which are broken with a single link to the assets folder.
Screenshots of the change:
Before
After
PR Checklist
npm run lintpasses