Skip to content

Commit

Permalink
feat(ad-hoc): remove unneeded dependencies (#185)
Browse files Browse the repository at this point in the history
Remove: cocoapods, ruby and bundler, xcpretty
  • Loading branch information
andrii-vysotskyi-cko authored Oct 24, 2023
1 parent 61a7f00 commit e011f3c
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 121 deletions.
6 changes: 1 addition & 5 deletions .github/actions/bootstrap-project/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ inputs:
runs:
using: "composite"
steps:
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.1.2'
bundler-cache: true
- name: Write Constants
run: |
CONSTANTS=$'${{ inputs.test-project-constants }}'
Expand All @@ -22,7 +18,7 @@ runs:
run: sudo xcode-select -s '/Applications/Xcode_15.0.app/Contents/Developer'
shell: bash
- name: Bootstrap Project
run: ./Scripts/BootstrapProject.sh --skip-bundle-instal
run: ./Scripts/BootstrapProject.sh
shell: bash
# - name: Bootstrap Example Project
# if: ${{ inputs.test-project-constants != '' }}
Expand Down
4 changes: 0 additions & 4 deletions Gemfile

This file was deleted.

99 changes: 0 additions & 99 deletions Gemfile.lock

This file was deleted.

1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ We welcome contributions of any kind including new features, bug fixes, and gene
- A recent version of macOS (tested with 13.3.1)
- A recent version of Xcode (tested with 14.3.1)
- [Homebrew](https://brew.sh/) package manager
- [Ruby](https://www.ruby-lang.org) (tested with 3.1.2) with [bundler](https://bundler.io) installed

### Installation

Expand Down
5 changes: 0 additions & 5 deletions Scripts/BootstrapProject.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,5 @@ export CURRENT_VERSION="$(cat Version.resolved)"
# Installs brew dependencies
brew bundle -q

# Installs bundler dependencies if needed
if ! [[ "$@" =~ '--skip-bundle-instal' ]]; then
bundle check || bundle install
fi

# Creates project
xcodegen generate
6 changes: 2 additions & 4 deletions Scripts/CreateXcframework.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,12 @@ function build_framework {(
xcodebuild archive \
-scheme $1 \
-destination "generic/platform=iOS" \
-archivePath .build/framework/$1-iOS |
bundle exec xcpretty
-archivePath .build/framework/$1-iOS

xcodebuild archive \
-scheme $1 \
-destination "generic/platform=iOS Simulator" \
-archivePath .build/framework/$1-Sim |
bundle exec xcpretty
-archivePath .build/framework/$1-Sim

cd .build/framework

Expand Down
4 changes: 3 additions & 1 deletion Scripts/PushPodspecs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@ set +e

# Push Podspecs
for PRODUCT in "ProcessOut" "ProcessOutCheckout3DS"; do
bundle exec pod trunk push $PRODUCT.podspec --allow-warnings --synchronous

# This script is intended to be run on CI where cocoapods is already installed.
pod trunk push $PRODUCT.podspec --allow-warnings --synchronous
done
3 changes: 1 addition & 2 deletions Scripts/Test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ done
xcodebuild clean build \
-project $PROJECT \
-scheme ProcessOutCheckout3DS \
-destination "generic/platform=iOS" |
bundle exec xcpretty
-destination "generic/platform=iOS"

# todo(andrii-vysotskyi): run example target tests when POM-144 is resolved

0 comments on commit e011f3c

Please sign in to comment.