Skip to content

Commit

Permalink
Only test on Blacklight 7, not 8
Browse files Browse the repository at this point in the history
  • Loading branch information
jrochkind committed Oct 10, 2023
1 parent 9e81b9e commit d6f8ff8
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
- ruby: '3.0'
rails_version: '7.0.4.1'
env:
BLACKLIGHT_VERSION: "~> 7.0" # only test on BL 7 for now
RAILS_VERSION: ${{ matrix.rails_version }}
ENGINE_CART_RAILS_OPTIONS: "--skip-git --skip-listen --skip-spring --skip-keeps --skip-action-cable --skip-coffee --skip-test ${{ matrix.engine_cart_rails_options }}"
steps:
Expand Down
8 changes: 8 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@ group :test do
gem 'activerecord-jdbcsqlite3-adapter', platform: :jruby
end

# While gemspec allows BL8 and some people are using BL8... the build
# has never actually passed on BL8 yet. We may choose to run tests on
# a blacklight version other than the latest allowed by gemspec, to get
# tests to pass, or to test on older BL still supported here.
if ENV['BLACKLIGHT_VERSION']
gem "blacklight", ENV['BLACKLIGHT_VERSION']
end

# BEGIN ENGINE_CART BLOCK
# engine_cart: 2.5.0
# engine_cart stanza: 2.5.0
Expand Down

0 comments on commit d6f8ff8

Please sign in to comment.