Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ViewComponent 3.0, by using with_SLOT api instead of deprecated 2.x slot API #240

Closed
wants to merge 1 commit into from
Closed

Support ViewComponent 3.0, by using with_SLOT api instead of deprecated 2.x slot API #240

wants to merge 1 commit into from

Commits on Oct 4, 2023

  1. use view_component with_SLOT api, instead of deprecated 2.x slot API 

    Deprecated 2.x Slot API was taken away in view_component [3.0.0](https://viewcomponent.org/CHANGELOG.html#v300).  By switching to with_SLOT_NAME API, we can support view_component 3.x.

The with_SLOTNAME API was introduced in view_component [2.54.0](https://viewcomponent.org/CHANGELOG.html#2540) (May 2022).  So we now express a dependency requiring view_component at least 2.54.0. As we do use view_components directly in source code here, it is appropriate to express it as a dependency, instead of just leaving it an indirect dependency.
    @jrochkind
    jrochkind committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    3162ce6 View commit details
    Browse the repository at this point in the history