Use ViewComponent Slots v2 API #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
view_component3
branch
2 times, most recently
from
69b1951
to
e8a725e
Compare
jcoyne
force-pushed
the
view_component3
branch
from
e8a725e
to
bf71f6e
Compare
|
I do not understand the But am super grateful to @jcoyne for getting us to green, AND with viewcomponent 3 support! I was totally blocked on that and don't think I would have been able to figure it out literally ever. I am going to go ahead and approve/merge this despite not totally following it, glad to be moving forward. Note (Cc @barmintor ) as a result of #241, we are now only testing on BL7, even though the gem still allows BL8, for those who have been using it all along on BL8 despite it never passing tests on BL8. |
This was referenced Oct 11, 2023
jrochkind
added a commit
that referenced
this pull request
Oct 12, 2023
With #242 to use Slots v2 API, we now require at least view_component 2.54.0, that's when it was introduced. https://viewcomponent.org/CHANGELOG.html#2540 I think we learned from #242 (and analagous things happening with other BL plugins) that if we're using ViewComponent API directly, as we are, we should declare a direct dependency on it, and what we know to work with, instead of just relying on indirect dependency from blacklight. So also adding a cap at , since a future 4 might include currently unknown backwards incompat changes that effect this code. I think this is just responsible dependency declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.