Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add direct view_component dependency #243

Merged
merged 1 commit into from
Oct 12, 2023
Merged

add direct view_component dependency #243

merged 1 commit into from
Oct 12, 2023

Commits on Oct 12, 2023

  1. add direct view_component dependency 

    With #242 to use Slots v2 API, we now require at least view_component 2.54.0, that's when it was introduced. https://viewcomponent.org/CHANGELOG.html#2540

I think we learned from #242 (and analagous things happening with other BL plugins) that if we're using ViewComponent API directly, as we are, we should declare a direct dependency on it, and what we know to work with, instead of just relying on indirect dependency from blacklight. So also adding a cap at , since a future 4 might include currently unknown backwards incompat changes that effect this code. I think this is just responsible dependency declaration.
    @jrochkind
    jrochkind committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    dbc4964 View commit details
    Browse the repository at this point in the history