Pin to solr version 9.6.1 #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the record, I believe this is because at this point latest This pin can probably be removed if solr_wrapper is fixed. See currently red cbeer/solr_wrapper#154 While this can make CI work again, this may still be very confusing for depending developers if they are trying to use solr_wrapper. |
|
This PR also contains code that looks like intended to support propshaft... is that intended @jcoyne or accidentally included? Not sure if it is accidental and partial and possibly break something? (but then CI is green, which is also odd!) |
|
@jrochkind Yeah. That was a mistake. I've updated so it's just the solr version change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.