Skip to content

Commit

Permalink
Merge pull request #166 from fasaxc/v1.1.x-series
Browse files Browse the repository at this point in the history
Pin Alpine to 3.6 and go-build to v0.8.
  • Loading branch information
bcreane authored Nov 22, 2017
2 parents 147236b + 5afd7e8 commit 05f23ea
Show file tree
Hide file tree
Showing 5 changed files with 45 additions and 44 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM alpine
FROM alpine:3.6
MAINTAINER Tom Denham <tom@projectcalico.org>
ADD dist/libnetwork-plugin /libnetwork-plugin
ENTRYPOINT ["/libnetwork-plugin"]
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ LOCAL_IP_ENV?=$(shell ip route get 8.8.8.8 | head -1 | awk '{print $$7}')
DOCKER_VERSION?=rc-dind
HOST_CHECKOUT_DIR?=$(CURDIR)
CONTAINER_NAME?=calico/libnetwork-plugin
CALICO_BUILD?=calico/go-build
CALICO_BUILD?=calico/go-build:v0.8
PLUGIN_LOCATION?=$(CURDIR)/dist/libnetwork-plugin
DOCKER_BINARY_CONTAINER?=docker-binary-container

Expand Down Expand Up @@ -54,7 +54,7 @@ build: $(SRC_FILES) vendor
CGO_ENABLED=0 go build -v -i -o dist/libnetwork-plugin -ldflags "-X main.VERSION=$(shell git describe --tags --dirty) -s -w" main.go

$(CONTAINER_NAME): dist/libnetwork-plugin
docker build -t $(CONTAINER_NAME) .
docker build --pull -t $(CONTAINER_NAME) .

# Perform static checks on the code. The golint checks are allowed to fail, the others must pass.
.PHONY: static-checks
Expand Down
75 changes: 38 additions & 37 deletions glide.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/custom_if_prefix/libnetwork_env_var_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ var _ = Describe("Running plugin with custom ENV", func() {

// Make sure the container has the routes we expect
routes := DockerString(fmt.Sprintf("docker exec -i %s ip route", name))
Expect(routes).Should(Equal("default via 169.254.1.1 dev test0 \n169.254.1.1 dev test0"))
Expect(routes).Should(Equal("default via 169.254.1.1 dev test0 \n169.254.1.1 dev test0 scope link"))

// Delete container
DockerString(fmt.Sprintf("docker rm -f %s", name))
Expand Down
6 changes: 3 additions & 3 deletions tests/default_environment/libnetwork_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ var _ = Describe("Libnetwork Tests", func() {

// Make sure the container has the routes we expect
routes := DockerString(fmt.Sprintf("docker exec -i %s ip route", name))
Expect(routes).Should(Equal("default via 169.254.1.1 dev cali0 \n169.254.1.1 dev cali0"))
Expect(routes).Should(Equal("default via 169.254.1.1 dev cali0 \n169.254.1.1 dev cali0 scope link"))

// Delete container
DockerString(fmt.Sprintf("docker rm -f %s", name))
Expand Down Expand Up @@ -204,7 +204,7 @@ var _ = Describe("Libnetwork Tests", func() {

// Make sure the container has the routes we expect
routes := DockerString(fmt.Sprintf("docker exec -i %s ip route", name))
Expect(routes).Should(Equal("default via 169.254.1.1 dev cali0 \n169.254.1.1 dev cali0"))
Expect(routes).Should(Equal("default via 169.254.1.1 dev cali0 \n169.254.1.1 dev cali0 scope link"))

// Delete container
DockerString(fmt.Sprintf("docker rm -f %s", name))
Expand Down Expand Up @@ -255,7 +255,7 @@ var _ = Describe("Libnetwork Tests", func() {

// Make sure the container has the routes we expect
routes := DockerString(fmt.Sprintf("docker exec -i %s ip route", name_subnet))
Expect(routes).Should(Equal("default via 169.254.1.1 dev cali0 \n169.254.1.1 dev cali0"))
Expect(routes).Should(Equal("default via 169.254.1.1 dev cali0 \n169.254.1.1 dev cali0 scope link"))

// Delete container and network
DockerString(fmt.Sprintf("docker rm -f %s", name_subnet))
Expand Down

0 comments on commit 05f23ea

Please sign in to comment.