Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update graphene-django #1140

Closed
wants to merge 1 commit into from
Closed

chore(deps): update graphene-django #1140

wants to merge 1 commit into from

Conversation

sbor23
Copy link

@sbor23 sbor23 commented Aug 4, 2020

Update to graphene-django 2.12.1 and fix connection field, schema.

fixes problem found in #985

@sbor23 sbor23 force-pushed the update-graphene-django-2.x branch from d13f50f to ddbc13e Compare August 5, 2020 08:38
@winged
Copy link
Contributor

winged commented Aug 5, 2020

LGTM, but note that this is a breaking change due to the schema changing types (String to ID; [String]! to [String!]!). Might wanna batch it and do it later when we have some other breaking changes as well (see #930 for example)

@sbor23
Copy link
Author

sbor23 commented Aug 5, 2020

LGTM, but note that this is a breaking change due to the schema changing types (String to ID; [String]! to [String!]!). Might wanna batch it and do it later when we have some other breaking changes as well (see #930 for example)

True. However I made the id input variable a graphene.String() to stay as close as possible to the existing schema.

@winged
Copy link
Contributor

winged commented Aug 5, 2020

LGTM, but note that this is a breaking change due to the schema changing types (String to ID; [String]! to [String!]!). Might wanna batch it and do it later when we have some other breaking changes as well (see #930 for example)

True. However I made the id input variable a graphene.String() to stay as close as possible to the existing schema.

It's still gonna break clients if they reference types

@sbor23 sbor23 force-pushed the update-graphene-django-2.x branch from ddbc13e to ab1f779 Compare March 8, 2021 13:12
@sbor23 sbor23 mentioned this pull request Mar 8, 2021
Closed
4 tasks
@sbor23 sbor23 force-pushed the update-graphene-django-2.x branch 3 times, most recently from d5b15af to 5b37ace Compare March 11, 2021 12:52
@sbor23 sbor23 mentioned this pull request Mar 11, 2021
Merged
chore(deps): update graphene-django
38518ab 
Update to graphene-django 2.12.1 and fix connection field, schema.
@sbor23 sbor23 force-pushed the update-graphene-django-2.x branch from 5b37ace to 38518ab Compare March 11, 2021 13:16
@sbor23
Copy link
Author

sbor23 commented Mar 24, 2021

Closing in favor of #1413 which incorporates these fixes.

@sbor23 sbor23 closed this Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winged winged Awaiting requested review from winged

@rhizoome rhizoome Awaiting requested review from rhizoome

@open-dynaMIX open-dynaMIX Awaiting requested review from open-dynaMIX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbor23 @winged