-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vulkan app can't display on iGPU in VM #83
Fix vulkan app can't display on iGPU in VM #83
Conversation
In VM if run vulkan on iGPU, i915_dev->has_fence_reg is 0, so DRM_IOCTL_I915_GEM_SET_TILING and DRM_IOCTL_I915_GEM_GET_TILING will never be invoked. Meanwhile if on dg2, i915_dev->has_fence_reg also is 0. So the flag 'i915_dev->has_fence_reg' can't be using to check if invoke GET_TILING,SET_TILING. Consider if run vulkan app not on dg2, should invoke GET_TILING,SET_TILING. Tracked-On: OAM-113503 Signed-off-by: Li, HaihongX <haihongx.li@intel.com>
57d537c
to
c6e6401
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failure when executing preintegration builder
FAILURE:CheckBug Bad comments/Bugs
More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/1049
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failure when executing preintegration builder
FAILURE:CheckBug Bad comments/Bugs
More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/1051
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR integrated into 'preintegration' builder
Your build ended in WARNING state. Please promote it carefully
More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/1052
Done by "Jiang, Fei" fei.jiang@intel.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failure when executing preintegration builder
FAILURE: CheckBug Bad comments/Bugs
More details, logs, and binaries: /absp/builders/celadon_smr0_master-premerge/builds/573
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR integrated into 'preintegration' builder
More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/1054
Done by "Jiang, Fei" fei.jiang@intel.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR integrated into 'premerge' builder
More details, logs, and binaries: /absp/builders/celadon_smr0_master-premerge/builds/575
Done by "Jiang, Fei" fei.jiang@intel.com
3b6760b
into
projectceladon:celadon/s/mr0/master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cactus finished building and testing your changes
It was requested for merge by cactusi@intel.com
so we merge it. Thanks for your contribution.
more details, logs, and binaries: /absp/builders/celadon_smr0_master-mergerequest/builds/591
In VM if run vulkan on iGPU, i915_dev->has_fence_reg is 0, so DRM_IOCTL_I915_GEM_SET_TILING and
DRM_IOCTL_I915_GEM_GET_TILING will never be invoked. Meanwhile if on dg2, i915_dev->has_fence_reg also is 0. So the flag 'i915_dev->has_fence_reg' can't be using to check if invoke GET_TILING,SET_TILING.
Consider if run vulkan app not on dg2, should invoke GET_TILING,SET_TILING.
Tracked-On: OAM-113503