-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alive Proxy into Options #5903
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -120,7 +120,7 @@ func (e *NucleiEngine) init(ctx context.Context) error { | |||||
_ = protocolinit.Init(e.opts) | ||||||
}) | ||||||
|
||||||
if e.opts.ProxyInternal && types.ProxyURL != "" || types.ProxySocksURL != "" { | ||||||
if e.opts.ProxyInternal && e.opts.AliveHttpProxy != "" || e.opts.AliveSocksProxy != "" { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix the logical operator in proxy condition. The condition combines multiple checks with incorrect operator precedence which could lead to unintended behavior. Apply this diff to fix the condition: -if e.opts.ProxyInternal && e.opts.AliveHttpProxy != "" || e.opts.AliveSocksProxy != "" {
+if e.opts.ProxyInternal && (e.opts.AliveHttpProxy != "" || e.opts.AliveSocksProxy != "") { 📝 Committable suggestion
Suggested change
|
||||||
httpclient, err := httpclientpool.Get(e.opts, &httpclientpool.Configuration{}) | ||||||
if err != nil { | ||||||
return err | ||||||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Update field name for consistency
Once the field name in types.go is updated to
AliveHTTPProxy
, this reference should be updated as well.📝 Committable suggestion