Relax patch-level dependency pin on intl_pluralrules #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intl_pluralrules dependency was pinned to a patch level release in ba16827, but I can't find any justification for it rematining that way. Since then we'ne unpinned alll remaining 3rd party crates to minor version levels instead of patch levels to give more flexability to downstream builds. We only pin patch realeases for other things in this workspace that we can reasonably expect to match at any given point.
The commit bump to v7.0.1 also happened before the v7.0.2 release existed, and looking at the upstream commits doesn't suggest to me any reason we shouldn't let people start building against that.