fix(client): diagnostics #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bevy diagnostics (measurements) should only record the change in the value since lass time the measurements were collected. _Not_ the life-time total.
Shatur
requested changes
Dec 16, 2024
|
@Shatur will do, plus I see that it needs fixing, I somehow managed to miss that stats are hidden behind a feature when running check/test. |
Shatur
approved these changes
Dec 16, 2024
UkoeHB
approved these changes
Dec 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
==========================================
+ Coverage 90.20% 90.22% +0.02%
==========================================
Files 46 46
Lines 2563 2569 +6
==========================================
+ Hits 2312 2318 +6
Misses 251 251 ☔ View full report in Codecov by Sentry. |
|
I will draft a new patch release this evening. |
|
@matoous the release is up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bevy diagnostics (measurements) should only record the change in the value since the last time the measurements were collected. Not the life-time total to my understanding. Using current implementation with bevy's
LogDiagnosticsPluginresults in logs such as:with ever-increasing number.