Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create and update rtree spatial index only when needed #179

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

wang-boyu
Copy link
Member

@wang-boyu wang-boyu commented Dec 24, 2023

Implements #104

Check performance of the gis example models. Execution time is the average of 10 runs, where each run contains model initialization followed by 10 steps.

model time in seconds time in seconds (this PR)
agents_networks
(num_agents=100)
3.18 0.44
agents_networks
(num_agents=500)
37.28 1.16
geo_schelling
(default parameters)
0.79 0.62
geo_schelling (points & polygons)
(default parameters)
1.49 1.19
geo_sir
(default parameters)
0.13 0.13
population
(default parameters)
12.88 10.31

@wang-boyu wang-boyu added this to the v0.7.0 milestone Dec 24, 2023
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9dfbe7c) 75.90% compared to head (205f850) 78.14%.

Files Patch % Lines
mesa_geo/geospace.py 84.61% 3 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   75.90%   78.14%   +2.23%     
==========================================
  Files          10       10              
  Lines         660      691      +31     
  Branches      138      151      +13     
==========================================
+ Hits          501      540      +39     
+ Misses        139      127      -12     
- Partials       20       24       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wang-boyu wang-boyu force-pushed the agentlayer/spatial-index branch 3 times, most recently from 36cce84 to e961994 Compare December 27, 2023 06:24
@wang-boyu wang-boyu force-pushed the agentlayer/spatial-index branch from e961994 to 205f850 Compare December 27, 2023 06:25
@wang-boyu wang-boyu marked this pull request as ready for review December 27, 2023 06:30
@wang-boyu
Copy link
Member Author

@Corvince @rht would you like to help review this PR? Thanks : )

@Corvince
Copy link
Contributor

Hi, yes, I can do that hopefully tonight or tomorrow!

@Corvince
Copy link
Contributor

Sorry I got some visitors, so it will take me some more days until I have a free evening

@wang-boyu
Copy link
Member Author

No worries! Enjoy your holidays.

@Corvince Corvince merged commit f9f7d6a into projectmesa:main Jan 4, 2024
11 checks passed
@Corvince
Copy link
Contributor

Corvince commented Jan 4, 2024

Finally reviewed and merged :)

Good job

@wang-boyu wang-boyu deleted the agentlayer/spatial-index branch January 5, 2024 00:13
@wang-boyu
Copy link
Member Author

Thanks for reviewing! Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants