Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml #227

Closed
wants to merge 1 commit into from
Closed

Update pyproject.toml #227

wants to merge 1 commit into from

Conversation

tpike3
Copy link
Member

@tpike3 tpike3 commented Aug 19, 2024

Attempting to fix build failure; fix is based on this documentation

There is a brute force fix where conf.py replace the kernel manually, but I would prefer not to use.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.30%. Comparing base (ce501b6) to head (db20d33).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   78.21%   78.30%   +0.08%     
==========================================
  Files          10        9       -1     
  Lines         693      765      +72     
  Branches      151      173      +22     
==========================================
+ Hits          542      599      +57     
- Misses        127      131       +4     
- Partials       24       35      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EwoutH
Copy link
Member

EwoutH commented Aug 19, 2024

I changed the repo in the Readthedocs settings from https://github.com/projectmesa/mesa-geo.git to https://github.com/projectmesa/mesa-geo, which I noticed after carefully comparing how it's configured for regular Mesa. I hope this fixes that it doesn't build on PRs.

@tpike3
Copy link
Member Author

tpike3 commented Aug 19, 2024

I changed the repo in the Readthedocs settings from https://github.com/projectmesa/mesa-geo.git to https://github.com/projectmesa/mesa-geo, which I noticed after carefully comparing how it's configured for regular Mesa. I hope this fixes that it doesn't build on PRs.

I just got it to build, I had to update my connection as documented here https://docs.readthedocs.io/en/stable/guides/pull-requests.html; <Username Dropdown> portion; it still didn't work so I am going to try one more thing

@EwoutH
Copy link
Member

EwoutH commented Aug 19, 2024

It works! #228

image

@tpike3
Copy link
Member Author

tpike3 commented Aug 19, 2024

Didn't work build still trying to start wrong kernel

@tpike3 tpike3 closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants