fix raster layer rendering in solaraviz #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wang-boyu
force-pushed
the
fix/raster-layer-in-solaraviz
branch
from
50dc9c8 to
1757ae8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
- Coverage 78.21% 73.48% -4.73%
==========================================
Files 10 10
Lines 693 856 +163
Branches 151 192 +41
==========================================
+ Hits 542 629 +87
- Misses 127 194 +67
- Partials 24 33 +9 ☔ View full report in Codecov by Sentry. |
rht
approved these changes
Oct 3, 2024
EwoutH
pushed a commit
to projectmesa/mesa-examples
that referenced
this pull request
Oct 17, 2024
This PR updates the remaining three gis examples to use Solara viz, partly addressing #154. It depends on projectmesa/mesa-geo#254 to be released, as these examples use raster layers. Also made some small adjustments in ordering components to account for the grid layout, instead of the previous column layout in Solara viz.
wang-boyu
added a commit
to wang-boyu/mesa-examples
that referenced
this pull request
Oct 17, 2024
This PR updates the remaining three gis examples to use Solara viz, partly addressing projectmesa#154. It depends on projectmesa/mesa-geo#254 to be released, as these examples use raster layers. Also made some small adjustments in ordering components to account for the grid layout, instead of the previous column layout in Solara viz.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raster layers were not rendered in the new SolaraViz. This PR should fix it.
Will update the raster gis examples after this is merged.