Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mantine dependency issues #37

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fix mantine dependency issues #37

merged 1 commit into from
Sep 13, 2023

Conversation

hossenlopp
Copy link
Contributor

@hossenlopp hossenlopp commented Sep 12, 2023 •
edited
Loading

Updates all mantine packages to use 4.2.12 versions. Addresses #36.

elsaperelli
elsaperelli requested changes Sep 13, 2023
View reviewed changes
Copy link

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mantine is up to version 6.0.20...we use 6.0.9 in our measure-repository-service frontend if we want to upgrade this even further...I think it might be worth it, but curious about your thoughts.

@elsaperelli elsaperelli self-assigned this Sep 13, 2023
@hossenlopp
Copy link
Contributor Author

Mantine is up to version 6.0.20...we use 6.0.9 in our measure-repository-service frontend if we want to upgrade this even further...I think it might be worth it, but curious about your thoughts.

My thought was to just get it functioning again. I think there could be some changes that wouldn't make the jump to 6.x trivial. We did do that for another project right? If you think it won't be too bad we can give it a try.

elsaperelli
elsaperelli approved these changes Sep 13, 2023
View reviewed changes
Copy link

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading to Mantine 6 will take some time...so this update will prevent errors on npm install until we do major updates.

@elsaperelli elsaperelli merged commit 673c4e9 into main Sep 13, 2023
1 check passed
@elsaperelli elsaperelli deleted the cthon-mantine-bump branch September 13, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsaperelli elsaperelli elsaperelli approved these changes

Assignees

@elsaperelli elsaperelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hossenlopp @elsaperelli