Skip to content

Commit

Permalink
earlier linting
Browse files Browse the repository at this point in the history
  • Loading branch information
nielstenboom committed Nov 21, 2023
1 parent a0ab072 commit 6c770b3
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ jobs:
config: packages/k8s/tests/test-kind.yaml
- run: npm install
name: Install dependencies
- run: npm run bootstrap
name: Bootstrap the packages
- run: npm run build-all
name: Build packages
- run: npm run format-check
- name: Check linter
run: |
npm run lint
git diff --exit-code -- ':!packages/k8s/tests/test-kind.yaml'
- run: npm run bootstrap
name: Bootstrap the packages
- run: npm run build-all
name: Build packages
- name: Run tests
run: npm run test
2 changes: 2 additions & 0 deletions packages/hooklib/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export async function getInputFromStdin(): Promise<HookData> {
return inputJson as HookData
}

//@ts-ignore
export function writeToResponseFile(filePath: string, message: any): void {
if (!filePath) {
throw new Error(`Expected file path`)
Expand All @@ -32,6 +33,7 @@ export function writeToResponseFile(filePath: string, message: any): void {
})
}

//@ts-ignore
function toCommandValue(input: any): string {
if (input === null || input === undefined) {
return ''
Expand Down
2 changes: 1 addition & 1 deletion packages/k8s/src/hooks/prepare-job.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
PodPhase
} from '../k8s/utils'
import { JOB_CONTAINER_NAME } from './constants'
import { CoreV1EndpointPort, HttpError } from '@kubernetes/client-node'
import { HttpError } from '@kubernetes/client-node'

export async function prepareJob(
args: prepareJobArgs,
Expand Down
1 change: 1 addition & 0 deletions packages/k8s/src/k8s/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ export async function createPod(
*
* https://lodash.com/docs/4.17.15#mergeWith
*/
//@ts-ignore
function podSpecCustomizer(objValue, srcValue, key): any[] | undefined {
if (['image', 'name', 'command', 'args'].includes(key)) {
return objValue
Expand Down

0 comments on commit 6c770b3

Please sign in to comment.