Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-blackbox-exporter] Remove toYaml from extraManifests template #5035

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iandrewt
Copy link
Contributor

@iandrewt iandrewt commented Dec 2, 2024

This allows the resources defined via the extraManifests value to have more 'helm-like' layouts when doing templating within them, such as having the template on the line beneath labels below:

extraManifests:
  - apiVersion: v1
     kind: MyCRD
     metadata:
       labels:
         {{- include "prometheus-blackbox-exporter.labels" . | nindent 4 }}

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer

This is a repeat of #4220, which was abandoned.

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

…late

Signed-off-by: Andrew Titmuss <iandrewt@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prometheus-blackbox-exporter] include in extra-manifests.yaml
1 participant