Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retention time hint #1812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Prashantsaini25
Copy link

@Prashantsaini25 Prashantsaini25 commented Jul 12, 2022

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Type of change

What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. Later this will be copied to the changelog file.


@@ -164,6 +164,8 @@ be created successfully.

Check the monitoring namespace (or the namespace you have specific in `namespace: `) and make sure the pods are running. Prometheus and Grafana should be up and running soon.

If you want to increase retention time make sure you will add retention: 1y in `prometheus-prometheus.yaml `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's the right place otherwise we would have to enumerate all possible settings. If your workflow is to update manually the YAML manifests generated by kube-prometheus then the right source of information is https://prometheus-operator.dev/docs/operator/api/#monitoring.coreos.com/v1.PrometheusSpec (it has a description of the CRD fields).
Having said there could be a parameter in https://github.com/prometheus-operator/kube-prometheus/blob/main/jsonnet/kube-prometheus/components/prometheus.libsonnet to define the retention value?

@github-actions github-actions bot added the stale label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants