Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate grafana config entries #2278

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Henni
Copy link

@Henni Henni commented Nov 19, 2023

Description

Fixes custom Grafana datasources being rendered twice.
Fixes #2277

I have only validated this for datasources and am not sure whether this change leads to issues with other configurations. Hoping to get a review by someone with more experience with this project and jsonnet as I'm pretty new to it ;)

Type of change

What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Fixes custom Grafana datasources being rendered twice.

- Fixes custom Grafana datasources being rendered twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Datasource Entries
1 participant