Adding template label #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znerol
requested changes
Jan 2, 2024
There was a problem hiding this comment.
Thanks @spearcrow for filing this PR. I left some comments inline.
Comment on lines
206
to
209
| 'template': GaugeMetricFamily( | ||
| 'pve_template', | ||
| 'Whether or not the VM/CT is template', | ||
| labels=['id']), |
There was a problem hiding this comment.
This adds a new metric. Judging from the feature request #199 I believe that a new label should be added on the existing pve_guest_info metric.
There was a problem hiding this comment.
Maybe just try to add the template key into the labels array instead? Look for that a couple of lines further down.
There was a problem hiding this comment.
Hi,
I've update the template key as labels in pve_guest_info.
I'm sorry if there is any mistake in my code, because I'm not a developer.
There was a problem hiding this comment.
Perfect. Thanks, this is working well against my cluster.
znerol
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I want to add template label for this issue #199
Can you check it?