fix: Replace multiple occurrences of token in fallback URL

prompt · Dec 13, 2024 · f836436 · f836436
1 parent 53eaba4
commit f836436
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@handles-net/handles-server",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "Verify Bluesky handles.",
   "keywords": [
     "bluesky",

diff --git a/server.test.ts b/server.test.ts
@@ -100,4 +100,22 @@ describe("Handles Server", () => {
       "https://example.com/domains/at.example.com?handle=not-registered.at.example.com",
     );
   });
+
+  test("Replaces multiple instances of token in fallback URL", async () => {
+    const res = await performRequest(
+      {
+        method: "GET",
+        url: "/",
+        headers: { Host: "not-registered.at.example.com" },
+      },
+      {
+        fallbackUrl: "https://example.com/{handle}?handle={handle}",
+      },
+    );
+
+    expect(res._getStatusCode()).toBe(307);
+    expect(res._getHeaders().location).toBe(
+      "https://example.com/not-registered.at.example.com?handle=not-registered.at.example.com",
+    );
+  })
 });
diff --git a/server.ts b/server.ts
@@ -72,7 +72,7 @@ export async function handleRequest(
 
   Object.entries({ domain, handle }).forEach(
     ([token, value]) =>
-      (noProfileDestination = noProfileDestination.replace(
+      (noProfileDestination = noProfileDestination.replaceAll(
         `{${token}}`,
         value,
       )),

diff --git a/tsconfig.json b/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "compilerOptions": {
     "baseUrl": ".",
-    "target": "es2016",
+    "target": "es2021",
     "module": "commonjs",
     "outDir": "./dist",
     "esModuleInterop": true,