Fix code quality issues.

composer.json

@@ -49,9 +49,12 @@
 		"overtrue/phplint": "^4.5",
 		"php-coveralls/php-coveralls": "^2.4",
 		"phpmd/phpmd": "^2.7",
+		"phpstan/phpstan": "^1.11",
 		"pronamic/pronamic-cli": "^1.0",
 		"pronamic/wp-coding-standards": "^1.3",
 		"roots/wordpress": "^6.0",
+		"szepeviktor/phpstan-wordpress": "^1.3",
+		"vimeo/psalm": "^0.3.14",
 		"wp-cli/wp-cli": "^2.3",
 		"wp-phpunit/wp-phpunit": "^6.1",
 		"yoast/phpunit-polyfills": "^1.0"

phpstan.neon.dist

@@ -1,9 +1,9 @@
 includes:
-	- vendor-bin/phpstan/vendor/szepeviktor/phpstan-wordpress/extension.neon
+	- vendor/szepeviktor/phpstan-wordpress/extension.neon
 parameters:
 	customRulesetUsed: false
 	level: max
-	bootstrapFiles:
-		- tests/phpstan/bootstrap.php
 	paths:
 		- src/
+	scanDirectories:
+		- wordpress/

src/Gateway.php

@@ -138,8 +138,10 @@ private function maybe_enrich_payment_methods() {
 			$payment_method->set_status( 'inactive' );
 		}
 
-		if ( null !== $buckaroo_transaction_specifications->Services ) {
-			foreach ( $buckaroo_transaction_specifications->Services as $service ) {
+		$services = is_object( $buckaroo_transaction_specifications ) && property_exists( $buckaroo_transaction_specifications, 'Services' ) ? $buckaroo_transaction_specifications->Services : null;
+
+		if ( null !== $services ) {
+			foreach ( $services as $service ) {
 				$payment_method_id = PaymentMethods::from_buckaroo_to_pronamic( $service->Name );
 
 				if ( null === $payment_method_id ) {
@@ -742,7 +744,7 @@ public function request( $method, $endpoint, $data = null ) {
 		/**
 		 * OK.
 		 */
-		return $object;
+		return (object) $object;
 	}
 
 	/**

src/PushController.php

@@ -94,6 +94,14 @@ private function handle_json_push( \WP_REST_Request $request ) {
 
 		$data = \json_decode( $json );
 
+		if ( ! is_object( $data ) || ! property_exists( $data, 'Transaction' ) ) {
+			return new \WP_Error(
+				'pronamic_pay_buckaroo_push_unknown_transaction',
+				'Unknown Buckaroo push transaction.',
+				[ 'status' => 500 ]
+			);
+		}
+
 		$transaction_key = $data->Transaction->Key;
 
 		/**
@@ -102,9 +110,11 @@ private function handle_json_push( \WP_REST_Request $request ) {
 		 * @link https://support.buckaroo.nl/categorie%C3%ABn/integratie/transactietypes-overzicht
 		 * @link https://dev.buckaroo.nl/PaymentMethods/Description/ideal
 		 */
-		foreach ( $data->Transaction->RelatedTransactions as $related_transaction ) {
-			if ( 'refund' === $related_transaction->RelationType ) {
-				$transaction_key = $related_transaction->RelatedTransactionKey;
+		if ( property_exists( $data->Transaction, 'RelatedTransactions' ) ) {
+			foreach ( $data->Transaction->RelatedTransactions as $related_transaction ) {
+				if ( 'refund' === $related_transaction->RelationType ) {
+					$transaction_key = $related_transaction->RelatedTransactionKey;
+				}
 			}
 		}