Support for multiple oauth use cases #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let developers save some CPU cycles and not deploy one heroku app per domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This change allows developers to create single heroku app to exchange github code for access token for multiple domains.
This may be useful if you are developing your app and you client_id/client_secret is bound to localhost domain, while in production you are using different combination of client_id/client_secret for production domain.
The PR also updates readme file to use official heroku CLI, instead of
cake.I know it's a lot of breaking changes, and this project is not actively supported anymore. But hey, if someone finds this useful, I'll be happy :).