Docker Build Pipeline with Tags #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example on how it looks in to container registry :
|
bdon
reviewed
Dec 4, 2023
bdon
reviewed
Dec 18, 2023
| - 'main' | ||
| tags: | ||
| - 'v*' | ||
| pull_request: |
There was a problem hiding this comment.
Is this pull_request key necessary - shouldn't it be canceled out by push: ${{ github.event_name != 'pull_request' }} on line 32?
|
Tagging @fraank original author of the GitHub action - does this PR work for Docker container usage? |
|
Merging this for now, will test out the tagged versions on GHCR, thanks! |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making Github Action that builds docker image with "version number" and "latest".
For example ghcr.io/protomaps/go-pmtiles:v0.0.7 & ghcr.io/gimse/go-pmtiles:latest
It still builds ghcr.io/protomaps/go-pmtiles:main on push to main.
It also run the pipeline on pull requests, but do not push to the registry.