Better error message for tile 404s if header/dirs are cached. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbarry
reviewed
Jan 27, 2024
pmtiles/server.go
Outdated
| if err != nil { | ||
| return 500, http_headers, []byte("Network error") | ||
| return 404, http_headers, []byte("Archive not found") |
There was a problem hiding this comment.
Could we pass through the actual error? Or at least log it. Also is archive missing the only kind of failure here? Up above I see it does 404 or 500 based on the if it's found or if an error occurred.
There was a problem hiding this comment.
I don't want to expose internal error messages over HTTP, many servers will be public facing.
Let me dig more into the failure scenarios where gocloud returns an error
There was a problem hiding this comment.
Ok that makes sense. Maybe if we just log the error then like if there's an error getting a directory?
bdon
force-pushed
the
serve-error-messages
branch
from
fa136c3
to
92a2f29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@msbarry