Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker multi platform support #139

Merged
merged 6 commits into from
Feb 12, 2024
Merged

Docker multi platform support #139

merged 6 commits into from
Feb 12, 2024

Conversation

jonasengelmann
Copy link
Contributor

closes #136

@bdon bdon mentioned this pull request Feb 12, 2024
Merged
bdon
bdon reviewed Feb 12, 2024
View reviewed changes
.github/workflows/publish.yml
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: docker/metadata-action@v5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like we lose the tagged versions on GHCR/Docker Hub by removing this, right? Is there an example somewhere we can follow that accomplishes this correctly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker/metadata-action@v5 is actually still there, it's here, but done for both images. I tried to follow this example and also tested it on my fork. It pushed to both dockerhub and ghcr.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the actions are not running on this PR, but we'll see, I'll tag a patch release. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Oh, because it was a PR to a PR)

@bdon bdon merged commit e16419c into protomaps:docker-multi-platform Feb 12, 2024
bdon added a commit that referenced this pull request Feb 12, 2024
@bdon @jonasengelmann
github actions build arm64 docker image [#136] (#138)
1f83ff6 
* github actions build arm64 docker image [#136]

* Docker multi platform support (#139)

---------

Co-authored-by: jonasengelmann <40031476+jonasengelmann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdon bdon bdon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasengelmann @bdon