Support Azure reload in case the file is changing #177
Conversation
|
confirmed working on azure storage cc @bdon |
| return ba.Bucket.Close() | ||
| } | ||
|
|
||
| type AzureBucketAdapter struct { |
There was a problem hiding this comment.
Is there a way to centralize this logic in the existing Bucket Adapter instead of creating separate implementations for each of (Azure, S3, etc)? That will be more maintainable in the long term and takes better advantage of gocloud.
There was a problem hiding this comment.
I've tried that in this updated version, there is nothing left in a "BaseBucketAdapter" cause everything we do here is using the provider specific APIs (As()), so it's not generic anymore.
The only common left is now in handleReaderResponse()
I think I almost prefer the explicit version with both adapters and a few repetitions,
|
I tested out an alternate approach that centralizes all the logic into https://github.com/protomaps/go-pmtiles/blob/azure-gcp-etags/pmtiles/bucket.go#L225 I also added support for Google Cloud, which uses integer generation IDs instead of string ETags. I think this approach takes better advantage of gocloud instead of requiring different concrete implementations, though it does make the single code path quite messy - this does get us to covering all of the cloud storage systems (s3, azblob, gs) so it shouldn't be more complicated unless some new platform emerges and is added. Btw, this seems to play well with the new Azure Container Apps deployment option I documented here: https://docs.protomaps.com/deploy/azure with Service Connector the connection string-based authentication to Blob Storage works with some small changes. Thanks for the PR and being patient with this. |
|
Implemented a different way in #183 |
Using the same logic as the S3 adapter, here is an Azure adapter that supports ETag and If-Match.
issue #176