Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to latest gocloud package. #182

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Bump to latest gocloud package. #182

merged 4 commits into from
Sep 10, 2024

Conversation

bdon
Copy link
Member

@bdon bdon commented Sep 4, 2024

  • Bump to gocloud v0.39.
  • This changes the default aws-sdk-go, used for S3-compatible blob storage, to aws-sdk-go-v2 instead, meaning the Provider-specific ETag support needs to change.
  • We could support both v1 and v2 (which now requires passing the awssdk=v1 flag), but given that they're deprecating v1 in early 2025: https://github.com/google/go-cloud/releases/tag/v0.39.0 we may as well just ignore it.

* aws sdk v1 will no longer work with etags, and is being deprecated soon anyways.
@bdon
Copy link
Member Author

bdon commented Sep 10, 2024

@msbarry this would affect DigitalOcean if it uses the S3-compatible blob driver.

@msbarry
Copy link
Contributor

msbarry commented Sep 10, 2024

Sounds good, it seems to work fine against digitalocean with this branch.

@bdon bdon merged commit 01b2278 into main Sep 10, 2024
4 checks passed
@bdon bdon deleted the gocloud-0-39 branch September 10, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants