Switch eth/v1 and v1alpha1 to protoc-gen-go-cast #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKiwi
requested review from
nisdas,
prestonvanloon,
rauljordan,
terencechain and
a team
as code owners
This reverts commit 617ed8d.
prestonvanloon
previously approved these changes
Apr 16, 2021
| @@ -0,0 +1,3 @@ | |||
| // +build ignore | |||
|
|
|||
| package ignore | |||
There was a problem hiding this comment.
Why do we need this? I forget...
There was a problem hiding this comment.
Part of the compilation output. I can try removing it in a later point but not in scope for this repo.
Comment on lines
1
to
4
| # gRPC Gateway | ||
|
|
||
| This package is contains generated files for applications that wish to use eth/v1alpha as a | ||
| [gRPC gateway](https://github.com/grpc-ecosystem/grpc-gateway). |
There was a problem hiding this comment.
Do you want to just delete this file? seems weird to clear out all of the contents.
There was a problem hiding this comment.
Replaced with a README in v1/ and v1alpha1/
This reverts commit b798ec6.
nisdas
reviewed
May 11, 2021
WORKSPACE
Outdated
| ], | ||
| ) | ||
|
|
||
| load("@io_bazel_rules_go//go:deps.bzl", "go_rules_dependencies", "go_register_toolchains") | ||
|
|
||
| go_rules_dependencies() | ||
|
|
||
| go_register_toolchains() | ||
| go_register_toolchains(version="1.15.5") |
There was a problem hiding this comment.
lets put this in parity with out current used go version in prysm 1.16.4 . Will also need rules_go to again be updated above. Same for gazelle
|
@nisdas the permissions are supposed to be 0644. |
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
prestonvanloon
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes eth/v1 and eth/v1alpha1 to use protoc-gen-go-cast entirely.
Also unites _gateway into the normal folders.
Please focus your review on the
.protofiles, the rest is mainly generated. The only changes should be extension tags.Dependencies are rather messy but would rather clean them up at a later point.
This in particular changes us from relying on the compilers at: "github.com/gogo/protobuf/proto"
To start using the native protobuf v2 compilers hosted at: "google.golang.org/protobuf/proto" (not github.com, thats v1)
More context on the changes here:
https://hackmd.io/wO5rzfVWS3GrS-L7FNXKGg