Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-3) Added parsing of psake tasks #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(GH-3) Added parsing of psake tasks #4

wants to merge 1 commit into from

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Nov 22, 2017

Description

Added the ability to parse the psakefile.ps1 file, looking for Task definitions. These are then provided for selection, and can be executed via the Integrated Terminal window.

Related Issue

#3

Motivation and Context

Allows the end user to easily "see" the build Tasks that they have available for their current project.

How Has This Been Tested?

Developer tests on my machine, needs much more testing, and comments.

Screenshots (if appropriate):

See related issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Still need to implement the actual command that is executed though when a task is selected
Copy link

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could add a command to psake that could use the PowerShell parser/ast to return the tasks rather than rely on regex's? We could have that command return JSON so it is more easily consumable from the extension.

@rkeithhill
Copy link

And there is already a command for that - Get-PSakeScriptTasks. Could call that and pipe to ConvertTo-Json to get output in JSON.

@gep13
Copy link
Member Author

gep13 commented Nov 23, 2017

@rkeithhill that is an interesting idea :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants