Merge pull request #322 from psteinroe/fix/has-more

fix: set hasMore to false if list is currently empty
psteinroe · Nov 8, 2023 · eb1ad24 · eb1ad24 · vercel · Nov 8, 2023
2 parents cff7840 + e225881
commit eb1ad24
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 2 deletions.
diff --git a/.changeset/small-keys-protect.md b/.changeset/small-keys-protect.md
@@ -0,0 +1,5 @@
+---
+"@supabase-cache-helpers/postgrest-core": patch
+---
+
+fix: set hasMore to false if result is currently empty
diff --git a/packages/postgrest-core/__tests__/mutate/transformers.spec.ts b/packages/postgrest-core/__tests__/mutate/transformers.spec.ts
@@ -0,0 +1,16 @@
+import { toHasMorePaginationCacheData } from '../../src/mutate/transformers';
+
+describe('toHasMorePaginationCacheData', () => {
+  it('should set hasMore to false if there are no items in the cache currently', async () => {
+    expect(toHasMorePaginationCacheData([{ test: 'a' }], [], 21)).toEqual([
+      {
+        data: [
+          {
+            test: 'a',
+          },
+        ],
+        hasMore: false,
+      },
+    ]);
+  });
+});
diff --git a/packages/postgrest-core/__tests__/upsert-item.spec.ts b/packages/postgrest-core/__tests__/upsert-item.spec.ts
@@ -776,7 +776,7 @@ describe('upsertItem', () => {
     ]);
   });
 
-  it('should set hasMore properky', async () => {
+  it('should set hasMore properly', async () => {
     expect(
       await mutateFnResult(
         { id_1: '0', id_2: '0', value: 'test' },

diff --git a/packages/postgrest-core/src/mutate/transformers.ts b/packages/postgrest-core/src/mutate/transformers.ts
@@ -31,7 +31,9 @@ export const toHasMorePaginationCacheData = <
         resultArray[chunkIndex] = {
           data: [],
           hasMore:
-            hasMoreCache[chunkIndex] ?? hasMoreCache[hasMoreCache.length - 1],
+            hasMoreCache[chunkIndex] ??
+            hasMoreCache[hasMoreCache.length - 1] ??
+            false,
         }; // start a new chunk
       }