code cosmetic #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increment patch version in CMakeLists.txt. Add src/include_rapidjson.h to mexoctaveSourceFiles. Centralize RapidJSON includes in include_rapidjson.h. Update RapidJSON commit hash in rapidJSON.cmake. Ensure type consistency with std::uint32_t casts in CziWriter.cpp. Simplify exception handling in argsutils.cpp, func_getsubblockbitmap.cpp, and func_open.cpp. Add array dimension checks and casts in func_addsubblock.cpp and utils.cpp. Add platform-specific UTF-8 to wide string conversion in utils.cpp.
Removed unnecessary #include directives for rapidjson in CziUtilities.cpp and CziUtilities.h to clean up the code. Added #pragma once to CziUtilities.h to prevent multiple inclusions and improve compilation efficiency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce warnings