-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow subscribing to a journey #201
Draft
derhuerst
wants to merge
8
commits into
main
Choose a base branch
from
subscriptions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89a7827
to
e3f1afe
Compare
With the current implementation, subscribing to a specific journey in the future (a different one than the next possible one on the route specified within
Lines 694 to 695 in e3f1afe
|
There's another call {
"channel": {
"active": false,
"address": "3b4b49491e1b1094be390ce6197a3fde1df6daaab33de17d37cf649ec8ec0aa7",
"channelId": "1952745D-F196-4775-B291-A5FCD84A81D4",
"name": "PUSH_IPHONE",
"options": [
{
"type": "NO_SOUND",
"value": "1"
},
{
"type": "CUSTOMER_TYPE",
"value": "com.deutschebahn.vrn"
}
],
"type": "IPHONE"
},
"userId": "B3B3CBF1-86F3-4280-BED4-F686A3624B1B"
} It is also being used to un-silence/re-activate, by just omitting the |
4a9c66b
to
90e7849
Compare
90e7849
to
31c75db
Compare
515e37f
to
5f054d0
Compare
5f054d0
to
829abdb
Compare
829abdb
to
891c720
Compare
891c720
to
e3edcdb
Compare
e3edcdb
to
049019d
Compare
049019d
to
e7b79f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to do:
subscribeToJourney()
issueupdateSubscription()
? allow subscribing to a journey #201 (comment)subscriptions: false
on all profiles that don't support it