Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggests improvement to introduction #156

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

clausmullie
Copy link
Contributor

No description provided.

@ericherman ericherman merged commit 955f1fd into develop Nov 21, 2023
2 checks passed
@clausmullie clausmullie deleted the Improves-introduction branch November 21, 2023 14:53
@ElenaFdR
Copy link
Member

ElenaFdR commented Nov 21, 2023

What was the logic behind changing the intro to the bulleted list of other things you might be interested in/looking for instead? It's very cognitively dissonant to include a list of stuff not on this page; presumably every webpage could have an infinite version of that list at the top.


See more of our work in:
Note this page does not include:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some punctuation or word missing in this sentence?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I am aware of - although it is perhaps more spoken English than written English.

@ElenaFdR? 👼

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking that either "Note, this page does not include:", "Note: this page does not include:" or "Note! This page does not include:" would be possible punctuations. Alternatively, "Note that this page does not include:" would sound better in my ears.

But thinking about it, it also seems odd as it is a very incomplete list of what this page does not include. If we have this bullet point list, I think going with your suggested "in addition to the resources below, also check out:" would be best.

@clausmullie
Copy link
Contributor Author

clausmullie commented Nov 21, 2023

@ElenaFdR I found it a bit confusing that the first list on the resources page is a See more of our work in: with a list of links to other places.

But yes, the new wording isn't optimal either. If f we want the header to orient readers to other things that are not resources, how about

in addition to the resources below, also check out:
*
*
*

Or if we keep the current wording of see more of our work, move it to the bottom of the page?

@clausmullie clausmullie restored the Improves-introduction branch November 22, 2023 08:17
@clausmullie clausmullie deleted the Improves-introduction branch November 22, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants