Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposes call to action for projects page #158

Merged
merged 6 commits into from
Nov 22, 2023
Merged

Conversation

clausmullie
Copy link
Contributor

Closes #4

Or is this too much ✨ ? I thought it might be a nice way to get people's attention.

@ericherman
Copy link
Member

Or is this too much ✨ ? I thought it might be a nice way to get people's attention.

The sparkles are a bit too over-the-top for my tastes ... especially being on both sides.

Perhaps others feel differently.

@ElenaFdR
Copy link
Member

I see where you're coming from, but I find the sparkles hard to spot when skimming down the page. Something brighter would work better.
How many projects would we have them on at any point? I would suggest no more than, say, 3, to preserve the 'specialness' of the marker. NB: we're also currently seeking feedback on the procurement process code.

@Ainali
Copy link
Member

Ainali commented Nov 22, 2023

I like the idea, but I think that the sparkles seem odd, as it usually highlights something that is good or new. And perhaps a single emoji at the start of the line is enough?

Perhaps a 💡 or 🛠️ would more symbolize that more work is needed here?

@clausmullie
Copy link
Contributor Author

NB: we're also currently seeking feedback on the procurement process code.

@ElenaFdR do you have a specific ask?

Ainali
Ainali previously approved these changes Nov 22, 2023
Ainali
Ainali previously approved these changes Nov 22, 2023
@clausmullie
Copy link
Contributor Author

For form I've taken out the introduction tweak from this PR

@clausmullie clausmullie requested a review from Ainali November 22, 2023 12:19
@clausmullie clausmullie merged commit 3883d1b into develop Nov 22, 2023
2 checks passed
@clausmullie clausmullie deleted the clausmullie-patch-1 branch November 22, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There should be a clear call to action on projects
4 participants