FEATURE: Make collection export option dynamic

[VladimirMikulic]

Demo

Resolves #522

@jywarren @sashadev-sky could you take a look at this? Thanks.

[sashadev-sky]

If we set it to undefined then won't it overwrite whatever custom collection the user passed in on initialization and always set it to this._group.generateExportJson?

Anyway can we bump the version to 0.11.2 in package.json for when we fix this? And also the problem appears when the export completes too, not just on cancel so we want to make sure to reset the collection then too.

Thank you for your help with the exporter! Really appreciate it. I'll upload this to the dashboard

[VladimirMikulic]

Thanks, @sashadev-sky. I've updated the PR.
If the user passes custom collection property, it won't reset it in cancelExport or when the export is completed. On the other hand, if the user hasn't specified the collection property it will reset it.

[sashadev-sky]

Ok awesome!! One more thing - should we remove the .images call at the end of JSON.stringify(opts.collection.images) and add it to the end of the generateExportJson calls instead, so that the user isn't forced to pass in their custom collection nested inside of an 'images' key?

From @jywarren's export.html file https://github.com/publiclab/Leaflet.DistortableImage/blob/main/examples/export.html it looks like we don't want to need that.

And I think you updated the Gruntfile.js file by accident. Also don't forget to bump package.json :)

[VladimirMikulic]

@sashadev-sky thank you! I apologise for committing Gruntfile changes, it's not efficient to run tests and linter on every change(I disable them in development). That's why I am trying to incorporate Webpack in this project :)

As you suggested I attached the .images to the generateExportJson function.
It's a good idea not forcing users to pass collection inside of a .images property.

In the end, I had the honour to bump package.json 🎉

[sashadev-sky]

@VladimirMikulic No prob! Yes you'll just want to run $ npm install $ npm install leaflet --no-save now so that the version updates in the package-lock.json and push that up too!

[VladimirMikulic]

Thanks @sashadev-sky, I've implemented the required changes.

[sashadev-sky]

Amazing!! Thank you so much for your help with the exporter, I need it!

CC @jywarren
and also @SidharthBansal this has been uploaded to GCI dashboard and @VladimirMikulic has completed it

[VladimirMikulic]

@sashadev-sky anytime! More changes coming soon. 🚀

[jywarren]

Oh my gosh already? My work over at publiclab/mapknitter#1192 is moving faster now, and I'm almost ready. Can you bump the package.json version by 0.0.1 and I can publish a new version? Thank you!

[VladimirMikulic]

@jywarren are you referring to me or to @sashadev-sky?

[jywarren]

Either, actually! If you open a PR with the version bump then either Sasha or I can run npm publish after merging it. Thanks!

[VladimirMikulic]

#525 :)

[sashadev-sky]

@VladimirMikulic The task is on GCI so make sure to claim it at some point :)

[VladimirMikulic]

Thanks @sashadev-sky. I've seen it there. I'll claim it after the 'calculateProjectiveTransform test' gets approved :)