Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up node to v16 #1728

Merged
merged 3 commits into from
May 27, 2022
Merged

up node to v16 #1728

merged 3 commits into from
May 27, 2022

Conversation

jywarren
Copy link
Member

for webgpu in #1714

for webgpu in #1714
@gitpod-io
Copy link

gitpod-io bot commented May 26, 2022

@codeclimate
Copy link

codeclimate bot commented May 26, 2022

Code Climate has analyzed commit 42c4c73 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1728 (1ad4c98) into main (d501aa4) will decrease coverage by 8.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1728      +/-   ##
==========================================
- Coverage   71.89%   63.47%   -8.43%     
==========================================
  Files          40       39       -1     
  Lines        1409     1180     -229     
==========================================
- Hits         1013      749     -264     
- Misses        396      431      +35     
Impacted Files Coverage Δ
lib/not_at_origin_validator.rb 85.71% <100.00%> (ø)
app/models/export.rb 30.55% <0.00%> (-69.45%) ⬇️
app/controllers/export_controller.rb 47.27% <0.00%> (-43.64%) ⬇️
app/controllers/application_controller.rb 88.23% <0.00%> (-0.66%) ⬇️
app/models/map.rb 91.61% <0.00%> (-0.65%) ⬇️
app/models/warpable.rb 88.50% <0.00%> (-0.14%) ⬇️
app/helpers/application_helper.rb 50.00% <0.00%> (ø)
app/controllers/maps_controller.rb 86.95% <0.00%> (ø)
app/controllers/sessions_controller.rb 33.33% <0.00%> (+0.42%) ⬆️

RUN echo "rvm_gems_path=/home/gitpod/.rvm" > ~/.rvmrc
RUN bash -lc "rvm install ruby-2.4.6 && rvm use ruby-ruby-2.4.6 --default"
RUN bash -lc "rvm install ruby-2.7.6 && rvm use ruby-ruby-2.7.6 --default"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, getting:


Step 3/4 : RUN bash -lc "rvm install ruby-2.7.6 && rvm use ruby-ruby-2.7.6 --default"
 ---> Running in b049f1523d7b
Already installed ruby-2.7.6.
To reinstall use:

    rvm reinstall ruby-2.7.6

Gemset '' does not exist, 'rvm ruby-2.7.6 do rvm gemset create ' first, or append '--create'.
The command '/bin/sh -c bash -lc "rvm install ruby-2.7.6 && rvm use ruby-ruby-2.7.6 --default"' returned a non-zero code: 2

Dunno why... why is 2.7.6 already installed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed steps here to find the error: gitpod-io/gitpod#9875

doing rvm uninstall ruby-2.7.6 didn't work to get it to pass... :-(

@jywarren jywarren closed this May 27, 2022
@jywarren jywarren reopened this May 27, 2022
@jywarren jywarren added the dependencies Pull requests that update a dependency file label May 27, 2022
@jywarren jywarren merged commit bb4dbb3 into main May 27, 2022
PeculiarE pushed a commit to PeculiarE/mapknitter that referenced this pull request Jul 6, 2022
* up node to v16

for webgpu in publiclab#1714

* Delete .travis.yml

* gitpod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant