-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Status.json #483
Create Status.json #483
Conversation
@icarito @jywarren I created an endpoint here You wanted this to be saved as a local JSON file now? Here is an example string of the full JSON it returns:
Note user_id is included above, so that covers the usernames @jywarren was asking about |
(will remove the console.logs when it should be merged) |
So, we can probably fetch the json here, and parse it instead of a simple
string response:
https://github.com/publiclab/mapknitter/blob/907f5b37f81cb5fc03c1f2f98a1ae6f57fd6ec30/app/views/maps/_sidebar_exports.html.erb#L104-L113
…On Fri, Apr 5, 2019 at 12:44 PM Sasha Boginsky ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/views/maps/_sidebar_exports.html.erb
<#483 (comment)>:
> @@ -112,6 +115,26 @@ var exporting, exportResolutionSlider
setInterval(exportProgress,5000)
Ok will do!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#483 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJwfb_4AsWeD90hkOAM9Gukesu5rEks5vd31kgaJpZM4cbhh3>
.
|
@jywarren Ok this is updated! I'll clean up the code and resolve merge conflict if / when you think this is ready to merge also in my last PR, for now updated the endpoint to mirror the old progress endpoint: |
@jywarren what is my next tasks after this? |
oh wow, does this work now? Can you update the screenshot? Awesome, it looks good! |
I think next step will be to allow for it to have a remote status.json file. So, we:
|
@jywarren ok you want this in this PR or a new one? |
3f7a05c
to
e5ae5b1
Compare
@jywarren I overrwrote the |
This is great. We can def. do the work on a remote status.json file in a follow-up. Is this ready to merge then? Awesome work, Sasha!!! |
@jywarren this failed due to keyserver issue, but it's ready to merge as soon as travis is back up and running! Just to confirm #413 or Leaflet.DistortableImage#203 is the next step? |
@jywarren update it worked! Please answer my question above too though :) Thank you!! |
Awesome. Either would be a great next step! |
* Export bug fix * Working export json * Update example view * Clean up code * Clean up code pt2 * Refactor export progress to show status JSON * Update demo view * Clean up comments
References #326
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!