Implement useReducer for textAreaValues #10867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| // the new comment form comes with an edit form, its toggle state needs to be created as well | ||
| // TODO: create multicase for "CREATE NEW COMMENT FORM" in reducers.js |
There was a problem hiding this comment.
Seems inapplicable because this is within a comment! Possible to skip?
|
Code Climate has analyzed commit bea891d and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
Hi @noi5e its great to hear from you! 🎉 This looks wonderful and many thanks. |
|
🎉 🎉 🎉 |
5 tasks
|
Thanks @jywarren! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again everyone! 👋🏽 I'd like to spend a couple of weeks finishing up a solid React rewrite of the commenting system! Toward the end, I'm going to write a bunch of planning issues so that other contributors can continue the work as needed.
Picking up from where I left off, I'm trying to simplify the app's
stateby using React'suseReducerfeature.(This issue is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issues #9069 and #9365 for more context)