Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Editor Constructor and Methods, Write Editor Getters #9110

Merged
merged 11 commits into from
Feb 4, 2021
Merged

Refactor Editor Constructor and Methods, Write Editor Getters #9110

merged 11 commits into from
Feb 4, 2021

Commits on Feb 1, 2021

  1. merge editor refactor branches publiclab#9004

    @noi5e
    noi5e committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    5dc442c View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. remove dropzone class publiclab#9004

    @noi5e
    noi5e committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    1bc9f25 View commit details
    Browse the repository at this point in the history

  2. add new constructor param; write getter methods; change E.method to t… 

    …his.method publiclab#9004
    @noi5e
    noi5e committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    a61264c View commit details
    Browse the repository at this point in the history

  3. call new E.textAreaValue getter publiclab#9004

    @noi5e
    noi5e committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    d1bb02b View commit details
    Browse the repository at this point in the history

  4. call new E.constructor; change imagebar IDs publiclab#9004

    @noi5e
    noi5e committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    8ef8d40 View commit details
    Browse the repository at this point in the history

  5. change preview ID selector publiclab#9004

    @noi5e
    noi5e committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    1eabf4f View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Merge branch 'main' into refactor-editor-constructor

    @noi5e
    noi5e authored Feb 4, 2021
    Configuration menu
    Copy the full SHA
    da777d0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor-editor-constructor

    @noi5e
    noi5e authored Feb 4, 2021
    Configuration menu
    Copy the full SHA
    01f7fca View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor-editor-constructor

    @noi5e
    noi5e authored Feb 4, 2021
    Configuration menu
    Copy the full SHA
    6c7ea4d View commit details
    Browse the repository at this point in the history

  4. delete typo from merge conflict publiclab#9004

    @noi5e
    noi5e committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    fde3b9f View commit details
    Browse the repository at this point in the history

  5. apply suggestions from code review 

    Co-authored-by: Sagarpreet <53554917+Sagarpreet@users.noreply.github.com>
    @noi5e @Sagarpreet
    noi5e and Sagarpreet authored Feb 4, 2021
    Configuration menu
    Copy the full SHA
    f3dae9f View commit details
    Browse the repository at this point in the history