Upgrade: Ruby 2.6, Rails 4.2 and Node 13 #499
Conversation
syntax changes and error fixes
fix integration tests and more syntax changes to fix errors
Revert "fix few functional tests" This reverts commit 5394a08b8c4bfbb08ea89f7e13dd8a45df637bf6. fix some functional tests
fix few functional tests
Upgrading ruby, node and rails version
|
Wow this is huge! I guess, i'd like to suggest we get this running in a staging instance, if possible. We are currently prioritizing the MapKnitter containerization (publiclab/mapknitter#1191) and then the utf-8/emoji issue on plots2 (publiclab/plots2#3007), but perhaps we can schedule some time for this after those? This is much appreciated! 🎉 🎉 🎉 🎉 |
Thanks Jeff, the cloud setup for MK has been finished at publiclab/mapknitter#1273 |
|
Great great job 🎉 🎉 @alaxalves ... do we have an "unstable" instance for this repo..maybe we could push it there and have folks test it for a day or two like we did with Mapknitter? before merge...what do you think? |
|
Yes, it's running at https://unstable.spectralworkbench.org/capture -- amazing! I tried saving a spectrum, though, and got a 500 error after being redirected here: https://unstable.spectralworkbench.org/spectrums
We don't have Sentry installed here, but it could make this debugging easier? @alaxalves were you able to save spectra locally? Looks like we are ALMOST THERE folks. This is amazing. @alaxalves thank you a zillion -- fingers 🤞 we get this last thing! |
Hmm, Yes I have! I'll check this out, maybe a config has changed in production 🤔 |
alaxalves
force-pushed
the
development
branch
10 times, most recently
from
d76e373
to
7cec07f
Compare
|
@jywarren Just fixed the Spectrum savings problem, I took advantage and fixed the protected attributes issue. |
|
Perfect! Thanks alax!! |
|
Great work! Congratulations!!!!! 🔥🔥🔥🔥🔥🔥 |
| @@ -163,7 +163,7 @@ def delete | |||
| def edit | |||
| @set = SpectraSet.find params[:id] | |||
| if @set.user_id == current_user.id || current_user.role == "admin" | |||
| @spectrums = Spectrum.find(:all, :limit => 4, :order => "created_at DESC") | |||
| @spectrums = Spectrum.all.order(created_at: :desc).limit(4) | |||
There was a problem hiding this comment.
Here we could take out .all but it may not be needed
| @@ -176,7 +176,7 @@ def search | |||
| end | |||
|
|
|||
| def recent | |||
| @spectrums = Spectrum.find(:all, :limit => 10, :order => "id DESC") | |||
| @spectrums = Spectrum.all.order(id: :desc).limit(10) | |||
| @@ -442,7 +442,7 @@ def clone_calibration | |||
| end | |||
|
|
|||
| def all | |||
| @spectrums = Spectrum.find(:all).paginate(:page => params[:page]) | |||
| @spectrums = Spectrum.all.paginate(:page => params[:page]) | |||
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
rake testPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software
Thanks!