Skip to content

Commit

Permalink
fix unsubscribeAll fix unsubscribe from channel group presence. (#261)
Browse files Browse the repository at this point in the history
* fix unsubscribeAll fix unsubscribe from channel group presence.

Fixes issue when unsubscribeAll is called and presence for channel groups was remaining subscribed.

* PubNub SDK v5.0.1 release.

Co-authored-by: Client Engineering Bot <60980775+Client Engineering Bot@users.noreply.github.com>
  • Loading branch information
phairow and Client Engineering Bot authored Mar 2, 2022
1 parent dd9c0db commit eae7f60
Show file tree
Hide file tree
Showing 16 changed files with 34 additions and 27 deletions.
10 changes: 7 additions & 3 deletions .pubnub.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
---
changelog:
- date: 2022-03-02
version: v5.0.1
changes:

- date: 2022-01-12
version: v5.0.0
changes:
Expand Down Expand Up @@ -1096,7 +1100,7 @@ supported-platforms:
- "Ubuntu 14.04 and up"
- "Windows 7 and up"
version: "Pubnub Javascript for Node"
version: "5.0.0"
version: "5.0.1"
sdks:
-
full-name: PubNub Javascript SDK
Expand All @@ -1115,7 +1119,7 @@ sdks:
distribution-type: source
distribution-repository: GitHub release
package-name: pubnub.js
location: https://github.com/pubnub/javascript/archive/refs/tags/v5.0.0.zip
location: https://github.com/pubnub/javascript/archive/refs/tags/v5.0.1.zip
requires:
-
name: "agentkeepalive"
Expand Down Expand Up @@ -1879,7 +1883,7 @@ sdks:
distribution-type: library
distribution-repository: GitHub release
package-name: pubnub.js
location: https://github.com/pubnub/javascript/releases/download/v5.0.0/pubnub.5.0.0.js
location: https://github.com/pubnub/javascript/releases/download/v5.0.1/pubnub.5.0.1.js
requires:
-
name: "agentkeepalive"
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## v5.0.1
March 02 2022

## v5.0.0
January 12 2022

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ You will need the publish and subscribe keys to authenticate your app. Get your
npm install pubnub
```
* or download one of our builds from our CDN:
* https://cdn.pubnub.com/sdk/javascript/pubnub.5.0.0.js
* https://cdn.pubnub.com/sdk/javascript/pubnub.5.0.0.min.js
* https://cdn.pubnub.com/sdk/javascript/pubnub.5.0.1.js
* https://cdn.pubnub.com/sdk/javascript/pubnub.5.0.1.min.js
2. Configure your keys:
Expand Down
6 changes: 3 additions & 3 deletions dist/titanium/pubnub.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! 5.0.0 / Consumer */
/*! 5.0.1 / Consumer */
exports["PubNub"] =
/******/ (function(modules) { // webpackBootstrap
/******/ // The module cache
Expand Down Expand Up @@ -597,7 +597,7 @@ var _default = function () {
}, {
key: "getVersion",
value: function getVersion() {
return '5.0.0';
return '5.0.1';
}
}, {
key: "_addPnsdkSuffix",
Expand Down Expand Up @@ -4075,7 +4075,7 @@ var _default = function () {
}

if (channelGroup in _this4._presenceChannelGroups) {
delete _this4._channelGroups[channelGroup];
delete _this4._presenceChannelGroups[channelGroup];
actualChannelGroups.push(channelGroup);
}
});
Expand Down
4 changes: 2 additions & 2 deletions dist/titanium/pubnub.min.js

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions dist/web/pubnub.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! 5.0.0 / Consumer */
/*! 5.0.1 / Consumer */
(function webpackUniversalModuleDefinition(root, factory) {
if(typeof exports === 'object' && typeof module === 'object')
module.exports = factory();
Expand Down Expand Up @@ -607,7 +607,7 @@ var _default = function () {
}, {
key: "getVersion",
value: function getVersion() {
return '5.0.0';
return '5.0.1';
}
}, {
key: "_addPnsdkSuffix",
Expand Down Expand Up @@ -5053,7 +5053,7 @@ function base64ToBinary(base64String) {
}

for (var byteIdx = byteOffset + 3; byteIdx >= byteOffset; byteIdx -= 1) {
if (view[byteIdx] === 0) {
if (view[byteIdx] === 0 && zeroBytesCount < 3) {
zeroBytesCount += 1;
}
}
Expand Down Expand Up @@ -6722,7 +6722,7 @@ var _default = function () {
}

if (channelGroup in _this4._presenceChannelGroups) {
delete _this4._channelGroups[channelGroup];
delete _this4._presenceChannelGroups[channelGroup];
actualChannelGroups.push(channelGroup);
}
});
Expand Down
8 changes: 4 additions & 4 deletions dist/web/pubnub.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/core/components/config.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/core/components/config.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/core/components/subscription_manager.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/core/components/subscription_manager.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/web/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/web/index.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pubnub",
"version": "5.0.0",
"version": "5.0.1",
"author": "PubNub <support@pubnub.com>",
"description": "Publish & Subscribe Real-time Messaging with PubNub",
"bin": {},
Expand Down
2 changes: 1 addition & 1 deletion src/core/components/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ export default class {
}

getVersion(): string {
return '5.0.0';
return '5.0.1';
}

_addPnsdkSuffix(name: string, suffix: string) {
Expand Down
2 changes: 1 addition & 1 deletion src/core/components/subscription_manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ export default class {
}
}
if (channelGroup in this._presenceChannelGroups) {
delete this._channelGroups[channelGroup];
delete this._presenceChannelGroups[channelGroup];
actualChannelGroups.push(channelGroup);
}
});
Expand Down

0 comments on commit eae7f60

Please sign in to comment.