Disable auto-retry for 403 #432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for subscrib auto-retry in case of 403.
After auto-retry disabled some tests has been broken.
|
@parfeon I'm just trying to close out PRs that I'm attached to. Is this PR still valid? |
|
Yup, but because of other work on SDKs it's priority has been changed. Will ask on planing about it. |
CraigLn
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(subscribe): disable auto-retry for 403
Disable automatic subscribe request retry after 403 has been received.
BREAKING CHANGES: subscribe loop will stop instead of retry after 1 second when 403 received.
test(acceptance): add 403 auto-retry test
Add tests for subscrib auto-retry in case of 403.