some test fixing #200
Merged
some test fixing #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguz-pubnub
reviewed
Nov 14, 2024
| @pytest.mark.asyncio | ||
| async def test_publish_mixed_via_post(event_loop): | ||
| pubnub = PubNubAsyncio(pnconf_copy(), custom_event_loop=event_loop) |
There was a problem hiding this comment.
What's the difference between pnconf_copy and pnconf_env_copy?
There was a problem hiding this comment.
pnconf_env* uses keyset from environmental variables instead of those hardcoded. I'm slowly cleaning up what was in the repo for a while now
jguz-pubnub
reviewed
Nov 14, 2024
| timeout=aiohttp.ClientTimeout(connect=self.config.connect_timeout), | ||
| connector=self._connector | ||
| ) | ||
| if not self._session: |
There was a problem hiding this comment.
Does it mean you will create a new session from now on if it's not presented before? What's the reason behind it? I mean why you had to change it?
There was a problem hiding this comment.
Some time ago I made this mistake of not having a single session connection, so this is the attempt to fix it
jguz-pubnub
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.